Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17349 Update emoji for English, plus a couple of fixes #3719

Merged
merged 1 commit into from
May 15, 2024
Merged

CLDR-17349 Update emoji for English, plus a couple of fixes #3719

merged 1 commit into from
May 15, 2024

Conversation

macchiati
Copy link
Member

CLDR-17349

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

Note: we are planning to do some further editing on the English to reduce overlapping terms. But this should be good enough to start Submission.

AEApple
AEApple reviewed May 14, 2024
View reviewed changes
common/annotations/en.xml Outdated
<annotation cp="😃" type="tts">grinning face with big eyes</annotation>
<annotation cp="😄">eye | face | grinning face with smiling eyes | mouth | open | smile</annotation>
<annotation cp="😄">eye | face | grinning face with smiling eyes | mouth | open | smile | grin | happy | laugh | lol | smiling | smiling face with open mouth &amp; smiling eyes</annotation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does &amp make sense from a search perspective?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed those. I retained them in 3 cases: annotations for & itself, and for 🔣 (so that it comes up if any of the symbols it shows are typed.

5faa546

AEApple
AEApple previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, although it does look like there are more annotations where two keywords appear both separately and together, unclear to me if that is expected or not going forward.

common/annotations/en.xml Show resolved Hide resolved
@macchiati
Copy link
Member Author

Another example

//ldml/annotations/annotation[@cp="😸"]
«animal | cat | eye | face | grin | grinning cat face with smiling eyes | grinning cat with smiling eyes | smile»
=>
«animal | cat | face | grinning | smiling | eyes»

macchiati added a commit to macchiati/cldr that referenced this pull request May 15, 2024
@macchiati
CLDR-17349 Update emoji for English, plus a couple of fixes
8eaae8e 
See unicode-org#3719
@macchiati macchiati force-pushed the CLDR-17349-Add-English-emoji branch from 5faa546 to 8eaae8e Compare May 15, 2024 00:34
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati macchiati requested a review from AEApple May 15, 2024 00:35
macchiati added a commit to macchiati/cldr that referenced this pull request May 15, 2024
@macchiati
CLDR-17349 Update emoji for English, plus a couple of fixes
7c32f03 
See unicode-org#3719
@macchiati macchiati force-pushed the CLDR-17349-Add-English-emoji branch from bfcb2f6 to 7c32f03 Compare May 15, 2024 01:08
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati macchiati force-pushed the CLDR-17349-Add-English-emoji branch from c6b447f to 6de92de Compare May 15, 2024 01:29
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati
Copy link
Member Author

Finally passing tests, so ready for review.

@macchiati macchiati merged commit b64beaf into unicode-org:main May 15, 2024
10 checks passed
@macchiati macchiati deleted the CLDR-17349-Add-English-emoji branch May 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedberg-icu pedberg-icu pedberg-icu approved these changes

@AEApple AEApple AEApple approved these changes

@stenshamn stenshamn Awaiting requested review from stenshamn

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macchiati @AEApple @pedberg-icu